[RIVER-15] Provide context information for logging in com.sun.jini.discovery.internal.X500Provider

• Type: Improvement
• Status: In Progress
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: jtsk_2.1
• Component/s: com_sun_jini_discovery
• Assignee: Unassigned
• Reporter: Mark Brouwer
• Created: 24/Mar/07 19:22
• Updated: 05/Oct/12 08:23

Description

The detailed logging for discovery is hard to read/unscramble to to a lack of context information at some points, see the example below:

24-Mar-2007 19:29:47 com.sun.jini.discovery.internal.X500Provider getPrivateCredentials (oid=1.3.6.1.4.12543.2.0, instance=master)
FINEST: obtained private credentials []
24-Mar-2007 19:29:47 com.sun.jini.discovery.internal.X500Provider getPrivateCredentials (oid=1.3.6.1.4.12543.2.0, instance=master)
FINEST: obtained private credentials [javax.security.auth.x500.X500PrivateCredential@1bbea67, javax.security.auth.x500.X500PrivateCredential@1a2cc7]

It took me stepping through a debugger to finally understand that the first getPrivateCredentials was for the RSA key algorithm and the second for the DSA key algorithm, so in this case the X500Provider.getPrivateCredentials method should have added the algoritm in the logging.

Also X500PrivateCredential has no proper string representation, so logging those is not very helpful. To me it seems that for logging purposes it is better to display the X.500 principal associated with the X.509 certificate from the private credentials.