Uploaded image for project: 'Apache Ripple'
  1. Apache Ripple
  2. RIPPLE-83

Cordova prepare logic is broken

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None

    Description

      Cordova prepare is executed on the first GET which has enablecordova in the query. However, this request will have User-Agent from the previous device. Hence, wrong file tree could be refreshed. For example, when switching between an iPad to an Android device, the following happens:

      refreshing project (platform: ios) ...
      ... done.
      Request: GET /?enableripple=cordova-3.0.0-Legend
      INFO: Set Device User Agent (String): "Mozilla/5.0 (Linux; U; Android 2.1; fr-fr; HTC Legend 1.32.163.1 Build/ERD79) AppleWebKit/530.17 (KHTML, like Gecko) Version/4.0 Mobile Safari/530.17"
      Request: GET /config.xml
      Request: GET /
      Request: GET /css/index.css
      Request: GET /cordova.js
      Request: GET /js/index.js
      Request: GET /img/logo.png
      

      Note that ios platform is prepared while android is served later for the session.

      Instead, prepare should be done when User-Agent is set and the server duly notified. A PR is on the way.

      Attachments

        Activity

          People

            Unassigned Unassigned
            busykai Arzhan Kinzhalin
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: