Uploaded image for project: 'REEF (Retired)'
  1. REEF (Retired)
  2. REEF-924

Use injectors given from Tang instead of empty ones in groupcomm evaluator-side

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 0.14
    • REEF-IO
    • None

    Description

      Group communication service instantiates many of its components by receiving an injection from a manually handled Injector instance. This Injector is created empty at first with Tang.Factory.getTang.newInjector(), which unfortunately prevents component classes from using other service configurations that may be residing in the same context or underlying contexts.
      Instead, we should receive a Injector object from Tang to do this so components can refer to other service configurations.

      I left out something in the original description: I was referring to evaluator-side group comm components. I'm not sure if we should do the same for driver-side components too, although I did check that using Tang-given injectors in driver-side group comm classes doesn't have any fatal effect on group communication, with the correct changes.

      Attachments

        Activity

          People

            jsjason Joo Seong Jeong
            jsjason Joo Seong Jeong
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: