[REEF-1683] Use default MaxRetryNumberInRecovery properly

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.16
• Labels: FT
• Assignee: Julia Wang
• Reporter: Julia Wang
• Created: 02/Dec/16 22:23
• Updated: 09/Dec/16 06:14
• Resolved: 06/Dec/16 19:51

Description

Currently in IMRUJobDefinitionBuilder, the default _maxRetryNumberInRecovery is set to 0. In REEFIMRUClient and some test code, we bind the value in IMRUJobDefinition to the named parameter MaxRetryNumberInRecovery. If the user doesn't set this value in IMRUJobDefinitionBuilder when creating IMRUJobDefinition, the default value 0 is bound to the NamedParameter, which override the named parameter MaxRetryNumberInRecovery's own default value.
In IMRUDriver, to avoid this override, we set another default value and replace the value passed in if it 0. That caused some confusion.
A correct way should be, if the user doesn't set, REEFIMRUClient should not bind 0 to the named parameter, that would allow the named parameter's own default value to be used. And when we look for the default value, the one set in the named parameter should be the unique place.

Issue Links

• Is contained by: REEF-1223 IMRU Fault Tolerance - restart failed evaluators