[REEF-1650] Log warning about unclean evaluator shutdown only if evaluator is not closing yet

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.16
• Component/s: REEF-Common
• Assignee: Mariia Mykhailova
• Reporter: Mariia Mykhailova
• Created: 24/Oct/16 17:29
• Updated: 24/Oct/16 19:57
• Resolved: 24/Oct/16 19:57

Description

Current code in Evaluators.java is

    for (final EvaluatorManager evaluatorManager : evaluatorsCopy) {
      LOG.log(Level.WARNING, "Unclean shutdown of evaluator {0}", evaluatorManager.getId());
      if (!evaluatorManager.isClosedOrClosing()) {
        evaluatorManager.close();
      }
    }

The warning about unclean shutdown is posted even for evaluators which are already closed or closing. We should move the log inside if statement, so that it is written only if action is taken to close the evaluator forcefully.