Uploaded image for project: 'REEF'
  1. REEF
  2. REEF-1650

Log warning about unclean evaluator shutdown only if evaluator is not closing yet

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.16
    • Component/s: REEF-Common
    • Labels:
      None

      Description

      Current code in Evaluators.java is

          for (final EvaluatorManager evaluatorManager : evaluatorsCopy) {
            LOG.log(Level.WARNING, "Unclean shutdown of evaluator {0}", evaluatorManager.getId());
            if (!evaluatorManager.isClosedOrClosing()) {
              evaluatorManager.close();
            }
          }
      

      The warning about unclean shutdown is posted even for evaluators which are already closed or closing. We should move the log inside if statement, so that it is written only if action is taken to close the evaluator forcefully.

        Attachments

          Activity

            People

            • Assignee:
              MariiaMykhailova Mariia Mykhailova
              Reporter:
              MariiaMykhailova Mariia Mykhailova
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: