Uploaded image for project: 'REEF'
  1. REEF
  2. REEF-1548

DriverStatusManager interface is not coherent

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: REEF Driver
    • Labels:

      Description

      Class DriverStatusManager manages the driver state and provides interface for state transitions, with methods like .onInit(), .onRunning(), .onError(), and such.

      In addition to that, it also has a method .sendJobEndingMessageToClient() that currently has nothing to do with the dirver's state transitions. That is, in some parts of REEF we use DriverStatusManager solely as the proxy to the job client.

      That duality in the class interface is not desirable, and I suspect that we can make the .sendJobEndingMessageToClient() method private and connect it to some driver state transition

        Attachments

          Activity

            People

            • Assignee:
              motus Sergiy Matusevych
              Reporter:
              motus Sergiy Matusevych
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: