Uploaded image for project: 'REEF'
  1. REEF
  2. REEF-1544

Use typed SubscriptionHandler instead of deprecated Subscription class

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: REEF-Common
    • Labels:

      Description

      Class Subscription is parameterized by token type, but in all use cases (in HandlerContainer class) it is used with type erasure, and the .unsubscribe() method checks for all possible subscription tokens manually. This is unsafe and hard to read. A safer mechanism is to use a new SubscriptionHandler class and deprecate and remove the old subscription logic.

        Attachments

          Activity

            People

            • Assignee:
              motus Sergiy Matusevych
              Reporter:
              motus Sergiy Matusevych
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:

                Time Tracking

                Estimated:
                Original Estimate - 1h
                1h
                Remaining:
                Remaining Estimate - 1h
                1h
                Logged:
                Time Spent - Not Specified
                Not Specified