[REEF-1057] Enable StyleCop.CSharp.NamingRules and fix violations

• Type: Sub-task
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Component/s: REEF.NET
• Assignee: Unassigned
• Reporter: Mariia Mykhailova
• Created: 09/Dec/15 20:37
• Updated: 18/Apr/16 22:30

Description

I suggest we adopt all rules, except SA1305 FieldNamesMustNotUseHungarianNotation, which doesn't have a lot of violations but complains about names like d2.

There are under 1100 violations of the rest of the rules, a small portion of them in autogenerated from Avro files which need to be excluded from StyleCop checks. The major offender (responsible for 874 of all violations) is SA1309 FieldNamesMustNotBeginWithUnderscore. Are we ok with adopting this rule, or do we consider it part of our style?

We might have to go through deprecation process for public names which we need to change.