Rave
  1. Rave
  2. RAVE-509

Move Person repository from rave-shindig to rave-core

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Critical Critical
    • Resolution: Unresolved
    • Affects Version/s: 0.8-INCUBATING
    • Fix Version/s: None
    • Component/s: rave-core, rave-shindig
    • Labels:
      None

      Description

      I recently upgraded from Rave 0.5 to Rave 0.8. The changes introduced in RAVE-345 caused major issues during the upgrade process. The problem is that the User and Person class are both in the same package/artifact (rave-core) but in different persistence units (persistence.xml). User is in the persistence unit of rave-core while Person is in the persistence unit of rave-shindig. This caused all kinds of classloading errors on JBoss application server .

      Since RAVE-345 made Person a first-class Rave concept I think it is wise to also move the repository to rave-core. In the process I also moved ApplicationData to rave-core.
      With these changes I'm currently able to deploy Rave in JBoss, as was the case when using 0.5. Please see attached patch. Note there's one minor issue with the patch, 2 tests in AbstractJpaRepositoryTest fail.

      With OpenJPA as the persistence provider, no Hibernate involved.

        Activity

        Hide
        Chris Geer added a comment -

        Is this still an issue?

        Show
        Chris Geer added a comment - Is this still an issue?
        Hide
        Raminderjeet Singh added a comment -

        Made task unassigned

        Show
        Raminderjeet Singh added a comment - Made task unassigned
        Hide
        Raminderjeet Singh added a comment -

        moved to version 0.11

        Show
        Raminderjeet Singh added a comment - moved to version 0.11
        Hide
        Richard Kettelerij added a comment -

        Hi Jasha,

        Failing tests are indeed blocking. What I meant was; please have a look at this patch and provide feedback on moving Person from shindig to core. I was planning to fix the tests once consensus was achieved. I'll have a look at RAVE-524 to see how it impacts this patch.

        Regards,
        Richard

        Show
        Richard Kettelerij added a comment - Hi Jasha, Failing tests are indeed blocking. What I meant was; please have a look at this patch and provide feedback on moving Person from shindig to core. I was planning to fix the tests once consensus was achieved. I'll have a look at RAVE-524 to see how it impacts this patch. Regards, Richard
        Hide
        Jasha Joachimsthal added a comment -

        Hi Richard,

        The OpenSocial Person can have a different persistence than the portal User. In our demo setup we have stored both in the same table. The portal retrieves the data as User, the OpenSocial container Shindig retrieves the data as Person.
        Due to the refactored project setup of RAVE-524 your patch doesn't work anymore. Failing unit tests are imo not minor issues, but blocking for applying the patch.

        What are the classloading errors in JBoss? Tomcat (6) doesn't seem to have them.

        Jasha

        Show
        Jasha Joachimsthal added a comment - Hi Richard, The OpenSocial Person can have a different persistence than the portal User. In our demo setup we have stored both in the same table. The portal retrieves the data as User, the OpenSocial container Shindig retrieves the data as Person. Due to the refactored project setup of RAVE-524 your patch doesn't work anymore. Failing unit tests are imo not minor issues, but blocking for applying the patch. What are the classloading errors in JBoss? Tomcat (6) doesn't seem to have them. Jasha
        Hide
        Richard Kettelerij added a comment - - edited

        Please let me know if you need more information or any other help. It would be great if this patch made it into the next (0.10) release.

        Show
        Richard Kettelerij added a comment - - edited Please let me know if you need more information or any other help. It would be great if this patch made it into the next (0.10) release.
        Hide
        Richard Kettelerij added a comment -

        Patch created against trunk dd. 12-03-2012.

        Show
        Richard Kettelerij added a comment - Patch created against trunk dd. 12-03-2012.

          People

          • Assignee:
            Unassigned
            Reporter:
            Richard Kettelerij
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:

              Development