Uploaded image for project: 'Ratis'
  1. Ratis
  2. RATIS-458

GrpcLogAppender#shouldWait should wait on pending log entries to follower

Agile BoardAttach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 0.5.0
    • gRPC

    Description

      In GrpcLogAppender when an append entry times out we remove the entry from the pendingRequests. This decreases the size of pendingRequests which affects the logic in GrpcLogAppender#shouldWait. Further we also consider heartbeats in shouldWait because heartbeats are tracked in pendingRequests. It should actually wait on the number of log entries which are appended to follower but have not yet been processed by it.

      GrpcConfigKeys.Server.leaderOutstandingAppendsMax should also be a fraction of RaftServerConfigKeys.Log.queueSize. This brings flow control for leader's append entries to follower because then number of outstanding append entries in leader would be limited by maximum number of operations in raft log worker.

      Attachments

        1. RATIS-458.001.patch
          5 kB
          Lokesh Jain
        2. RATIS-458.002.patch
          5 kB
          Lokesh Jain
        3. RATIS-458.003.patch
          5 kB
          Lokesh Jain
        4. RATIS-458.004.patch
          0.8 kB
          Lokesh Jain
        5. RATIS-458.005.patch
          2 kB
          Lokesh Jain
        6. RATIS-458.006.patch
          11 kB
          Lokesh Jain
        7. RATIS-458.007.patch
          15 kB
          Lokesh Jain
        8. RATIS-458.008.patch
          23 kB
          Lokesh Jain
        9. RATIS-458.009.patch
          23 kB
          Lokesh Jain

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            ljain Lokesh Jain
            ljain Lokesh Jain
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment