[RATIS-1500] Fix LogAppender NN_NAKED_NOTIFY

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.3.0
• Component/s: server
• Assignee: Tsz-wo Sze
• Reporter: Tsz-wo Sze
• Created: 22/Jan/22 07:43
• Updated: 15/Nov/22 06:54
• Resolved: 24/Jan/22 20:05

Description

In LogAppender, we have suppressed the NN_NAKED_NOTIFY findbugs warning.

  @SuppressFBWarnings("NN_NAKED_NOTIFY")
  default void notifyLogAppender() {
    synchronized (this) {
      notify();
    }
  }

See http://findbugs.sourceforge.net/bugDescriptions.html#NN_NAKED_NOTIFY

Issue Links

• causes: RATIS-1745 Improve performance of AwaitForSignal by reducing amount of exceptions created
• is duplicated by: RATIS-985 Reduce notify() in GrpcLogAppender::onNextImpl
• is related to: RATIS-1552 Fix StateMachineUpdater NN_NAKED_NOTIFY
• relates to: RATIS-1497 Avoid using ForkJoinPool.commonPool() in GrpcClientProtocolService
• links to: GitHub Pull Request #588