[RATIS-1277] Fix FileStore write failed because reply out of order

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0.0
• Assignee: runzhiwang
• Reporter: runzhiwang
• Created: 30/Dec/20 11:29
• Updated: 31/Dec/20 10:41
• Resolved: 31/Dec/20 10:41

Description

As the following image and code shows, the code check the byteWritten of STREAM_HEADER, i.e. 0, equals to 10000, of course failed.

static boolean checkSuccessRemoteWrite(List<CompletableFuture<DataStreamReply>> replyFutures, long bytesWritten) {
    for (CompletableFuture<DataStreamReply> replyFuture : replyFutures) {
      final DataStreamReply reply = replyFuture.join();
      if (!reply.isSuccess() || reply.getBytesWritten() != bytesWritten) {
        + System.err.println("succ:" + reply.isSuccess() + " reply written:" + reply.getBytesWritten() +
        +    " expected:" + bytesWritten + " clientId:" + reply.getClientId() + ",type:" + reply.getType() + ",streamId" +
        +    reply.getStreamId() + ",offset:" + reply.getStreamOffset() + ",datalength:" + reply.getDataLength());
        return false;
      }
    }
    return true;
  }

Issue Links

• links to: GitHub Pull Request #389