Uploaded image for project: 'Ranger'
  1. Ranger
  2. RANGER-387

gettter/setter inconsistent names - RangerServiceDef - setType()/getName()

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.5.0
    • Fix Version/s: 0.5.0
    • Component/s: plugins
    • Labels:
      None

      Description

      A pair of getter/setter has inconsistent names: getName() and setType() in RangerServiceDef. This should be fixed to be consistent.

      Though 'type' seems to be a better choice than name for ServiceDefs, to minimize the number of references that needs to be updated, it will be easier to change setType() to setName(). Changing 'name' to 'type' would require changes across a lot of files - including service-def JSON files.

      So I propose to rename RangerServiceDef.setType() to RangerServiceDef.setName().

        Attachments

          Activity

            People

            • Assignee:
              madhan.neethiraj Madhan Neethiraj
              Reporter:
              madhan.neethiraj Madhan Neethiraj
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: