[RANGER-2879] Improve performance of incrementally updating policies

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 2.0.0
• Component/s: plugins
• Assignee: star
• Reporter: star
• Created: 29/Jun/20 08:05
• Updated: 10/Dec/22 07:26

Description

There is large amount of deleting policy operation in incrementally updating mechanism. But policies in RangerPolicyRepository is a List<RangerPolicy>. 

//
private void removePolicy(Long id) {
    if (LOG.isDebugEnabled()) {
        LOG.debug("==> RangerPolicyRepository.removePolicy(" + id +")");
    }
    Iterator<RangerPolicy> iterator = policies.iterator();
    while (iterator.hasNext()) {
        if (id.equals(iterator.next().getId())) {
            iterator.remove();
            break;
        }
    }

    policyEvaluatorsMap.remove(id);

    if (LOG.isDebugEnabled()) {
        LOG.debug("<== RangerPolicyRepository.removePolicy(" + id +")");
    }
}

Replace list with a map structure will improve performance of removePolicy a lot.

 

 

Issue Links

• is related to: RANGER-2658 Support million policies in ranger.