[RANGER-2563] Optimize the code, keep the code style consistent and remove the invalid code in the embeddedwebserver project

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 2.1.0
• Component/s: Ranger
• Labels: patch
• Flags: Patch
• Assignee: wu.kehua
• Reporter: wu.kehua
• Created: 10/Sep/19 11:09
• Updated: 10/Sep/19 11:17

Description

1. Change from "System.err.println("err response: " + response);"
to "logger.severe("Error response: " + response);"

2. Remove invalid code

private void uploadFileToZk(SolrZkClient zkClient, Path filePath,
		Path configsPath) throws FileNotFoundException {
	InputStream is = new FileInputStream(filePath.toString());
	try {
		if (zkClient.exists(configsPath.toString(), true)) {
			zkClient.setData(configsPath.toString(),
					IOUtils.toByteArray(is), true);
		} else {
			zkClient.create(configsPath.toString(),
					IOUtils.toByteArray(is), CreateMode.PERSISTENT, true);
		}
	} catch (Exception e) {
		throw new IllegalStateException(e);
	} finally {
		IOUtils.closeQuietly(is);
	}
}

private String getConfigFileName() { private String getConfigFileName() { 
        return SOLR_CONFIG_FILE; 
}

3. Change the parameter "CrendentialProviderPath" to "crendentialProviderPath"

Issue Links

• links to: https://reviews.apache.org/r/71462/