[RANGER-1965] Prevent NPE on decrypting a null password

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.0.0
• Component/s: admin
• Assignee: Colm O hEigeartaigh
• Reporter: Colm O hEigeartaigh
• Created: 29/Jan/18 16:17
• Updated: 30/Jan/18 10:04
• Resolved: 30/Jan/18 10:04

Description

If no password is specified, the logs show a NPE:

java.lang.NullPointerException
    at com.sun.jersey.core.util.Base64.decode(Base64.java:324)
    at org.apache.ranger.plugin.util.PasswordUtils.decrypt(PasswordUtils.java:126)
    at org.apache.ranger.plugin.util.PasswordUtils.decryptPassword(PasswordUtils.java:120)
    at org.apache.ranger.plugin.client.BaseClient.login(BaseClient.java:108)
    at org.apache.ranger.plugin.client.BaseClient.<init>(BaseClient.java:61)
    at org.apache.ranger.services.sqoop.client.SqoopClient.<init>(SqoopClient.java:74)
    at org.apache.ranger.services.sqoop.client.SqoopClient.getSqoopClient(SqoopClient.java:357)
    at org.apache.ranger.services.sqoop.client.SqoopClient.connectionTest(SqoopClient.java:321)

Instead, we should only try to decrypt the password if it's not null.

Issue Links

• links to: Review Request