[RANGER-1863] Optimize the code and keep the code style consistent, remove the invalid code in the RemoteUnixLoginModule class

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: master
• Fix Version/s: 1.0.0, master
• Component/s: usersync
• Flags: Patch
• Assignee: peng.jianhua
• Reporter: peng.jianhua
• Created: 30/Oct/17 03:17
• Updated: 03/Nov/17 08:25
• Resolved: 03/Nov/17 08:25

Description

Optimize the code and keep the code style consistent, remove the invalid code in the LoginModule class

1.Change from "serverCertValidation = (! (certValidationFlag != null && ("false".equalsIgnoreCase(certValidationFlag.trim().toLowerCase()))));"
to "serverCertValidation = (! (certValidationFlag != null && ("false".equalsIgnoreCase(certValidationFlag.trim().))));"

2.Change from "System.err.println("Skipping RemoteLogin - [" + JAAS_ENABLED_PARAM + "] => [" + val + "]");"
to "log("Skipping RemoteLogin - [" + JAAS_ENABLED_PARAM + "] => [" + val + "]");"
3.remove invalid code /*
Properties config = null;

String val = (String) options.get(REMOTE_UNIX_AUTHENICATION_CONFIG_FILE_PARAM);
log("Remote Unix Auth Configuration file [" + val + "]");
if (val != null)

{ XMLUtils.loadConfig(val, config); }

if (config == null)

{ logError("Remote Unix Auth Configuration is being loaded from XML configuration - not Properties"); config = new Properties(); config.putAll(options); }

*/

Issue Links

• links to: https://reviews.apache.org/r/63404/