Uploaded image for project: 'Ranger'
  1. Ranger
  2. RANGER-1863

Optimize the code and keep the code style consistent, remove the invalid code in the RemoteUnixLoginModule class

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: master
    • Fix Version/s: 1.0.0, master
    • Component/s: usersync
    • Labels:
      None
    • Flags:
      Patch

      Description

      Optimize the code and keep the code style consistent, remove the invalid code in the LoginModule class

      1.Change from "serverCertValidation = (! (certValidationFlag != null && ("false".equalsIgnoreCase(certValidationFlag.trim().toLowerCase()))));"
      to "serverCertValidation = (! (certValidationFlag != null && ("false".equalsIgnoreCase(certValidationFlag.trim().))));"

      2.Change from "System.err.println("Skipping RemoteLogin - [" + JAAS_ENABLED_PARAM + "] => [" + val + "]");"
      to "log("Skipping RemoteLogin - [" + JAAS_ENABLED_PARAM + "] => [" + val + "]");"
      3.remove invalid code /*
      Properties config = null;

      String val = (String) options.get(REMOTE_UNIX_AUTHENICATION_CONFIG_FILE_PARAM);
      log("Remote Unix Auth Configuration file [" + val + "]");
      if (val != null)

      { XMLUtils.loadConfig(val, config); }

      if (config == null)

      { logError("Remote Unix Auth Configuration is being loaded from XML configuration - not Properties"); config = new Properties(); config.putAll(options); }

      */

        Attachments

          Activity

            People

            • Assignee:
              peng.jianhua peng.jianhua
              Reporter:
              peng.jianhua peng.jianhua
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: