[RANGER-1444] Do some code improvement in security admin module

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0.0
• Fix Version/s: 1.0.0
• Component/s: admin
• Assignee: Qiang Zhang
• Reporter: Qiang Zhang
• Created: 10/Mar/17 07:10
• Updated: 11/Mar/17 02:52
• Resolved: 11/Mar/17 02:52

Description

1. There are some duplicate codes in method mapXXPortalUserToVXPortalUserForDefaultAccount.

userProfile.setLoginId(user.getLoginId());
userProfile.setEmailAddress(user.getEmailAddress());
userProfile.setStatus(user.getStatus());
userProfile.setUserRoleList(new ArrayList<String>());
userProfile.setId(user.getId());
userProfile.setFirstName(user.getFirstName());
userProfile.setLastName(user.getLastName());
userProfile.setPublicScreenName(user.getPublicScreenName());
userProfile.setEmailAddress(user.getEmailAddress());

We set the email address twice.
2. We have already checked if sess is null, so don't need to check it in below logic.

UserSessionBase sess = ContextUtil.getCurrentUserSession();
if (sess != null) {
	if (sess != null && sess.isUserAdmin() || sess.isKeyAdmin()) {
		return;
	}
	if (sess.getXXPortalUser().getId().equals(gjUser.getId())) {
		return;
	}
}