[RANGER-1431] Do some code improvement in Java method AuthSessionService.mapEntityToViewBean

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: master
• Fix Version/s: 1.0.0, 0.7.1
• Component/s: admin
• Labels: patch
• Flags: Patch
• Assignee: Qiang Zhang
• Reporter: Qiang Zhang
• Created: 08/Mar/17 02:02
• Updated: 11/Sep/17 01:30
• Resolved: 09/Mar/17 01:07

Description

In method mapEntityToViewBean of class \security-admin\src\main\java\org\apache\ranger\service\AuthSessionService.java,
there is some code can be improved:
1.The following code is repated twice, remove one of them.

viewObj.setLastName(gjUser.getLastName());

2.Check null before using gjUser.

XXPortalUser gjUser = daoMgr.getXXPortalUser().getById(resource.getUserId());

3.Family name should be last name instead of email address.

viewObj.setFamilyScreenName(gjUser.getEmailAddress());