[RANGER-1287] Remove code duplication from Java method EmbeddedServer.start()

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Duplicate
• Affects Version/s: 0.7.0
• Fix Version/s: 0.7.0
• Component/s: admin
• Labels: patch
• Assignee: Qiang Zhang
• Reporter: Qiang Zhang
• Created: 03/Jan/17 07:16
• Updated: 19/Jan/17 14:09
• Resolved: 19/Jan/17 14:08

Description

In java class incubator-ranger\embeddedwebserver\src\main\java\org\apache\ranger\server\tomcat\EmbeddedServer.java,
there is some code duplication in method start().
1.The following code is repeated twice, should remove one of them.

valve.setRotatable(true);

2.The following code is repeated three times which can be refactored.

try{
	server.start();
	server.getServer().await();
	shutdownServer();
}catch (LifecycleException e) {
	LOG.severe("Tomcat Server failed to start:" + e.toString());
	e.printStackTrace();
}catch (Exception e) {
	LOG.severe("Tomcat Server failed to start:" + e.toString());
	e.printStackTrace();
}

Issue Links

• duplicates: RANGER-1316 Ranger-Admin enable security mode should not depend on configuration logdir