Description
In java class incubator-ranger\embeddedwebserver\src\main\java\org\apache\ranger\server\tomcat\EmbeddedServer.java,
there is some code duplication in method start().
1.The following code is repeated twice, should remove one of them.
valve.setRotatable(true);
2.The following code is repeated three times which can be refactored.
try{ server.start(); server.getServer().await(); shutdownServer(); }catch (LifecycleException e) { LOG.severe("Tomcat Server failed to start:" + e.toString()); e.printStackTrace(); }catch (Exception e) { LOG.severe("Tomcat Server failed to start:" + e.toString()); e.printStackTrace(); }
Attachments
Attachments
Issue Links
- duplicates
-
RANGER-1316 Ranger-Admin enable security mode should not depend on configuration logdir
- Resolved