[QPIDJMS-93] Extract proper error from Rejected disposition to avoid NPE as cause of a JMSException

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.1.0, 0.2.0, 0.3.0, 0.4.0
• Fix Version/s: 0.5.0
• Component/s: qpid-jms-client
• Assignee: Timothy A. Bish
• Reporter: Timothy A. Bish
• Created: 19/Aug/15 19:44
• Updated: 06/Jan/16 12:33
• Resolved: 19/Aug/15 19:54

Description

When an send is answered with a Rejected disposition we don't try to extract the error from the outcome and this result in no Exception being propagated up to the exception dispatcher which leads to an NPE getting set into the JMSException we fire.

This also impacts error detection when the connection is set to always sync send and a broker like ActiveMQ sends back an error on a send. Without the outcome error lookup we fail to properly throw a JMSException from a failed send because the error value that propagates up is null.