[QPIDJMS-60] using 'nested options' causes issues when adding/removing a URI from the pool object

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.2.0
• Fix Version/s: 0.3.0
• Component/s: qpid-jms-client
• Assignee: Timothy A. Bish
• Reporter: Robbie Gemmell
• Created: 29/May/15 11:15
• Updated: 06/Jan/16 12:32
• Resolved: 29/May/15 19:15

Description

The failover provider allows adding and removing URIs from the FailoverUriPool object. This support is used by the Discovery layer to update the applicable URIs. The methods may not have the intended effect if there are 'nested options' in use however.

The add method on the pool manipulates the given URI by adding any 'nest options' to it before insertion. It does this after checking the original URI wasnt already in the pool. That probably means that if there are nested options then adding the same URI again will insert a new entry when it wouldnt be expected to.

The remove method does not manipulate the given URI, so if it doesnt have the nested options applied to it already then it wont actually get removed from the list.