[QPIDJMS-498] race during concurrent creation of initial connection

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.50.0
• Fix Version/s: 0.51.0
• Component/s: qpid-jms-client
• Assignee: Robbie Gemmell
• Reporter: Robbie Gemmell
• Created: 20/Apr/20 15:49
• Updated: 24/Apr/20 13:52
• Resolved: 20/Apr/20 16:01

Description

There is a race within some handling code for loading/creation of underlying client objects during creation of a connection which can occur during concurrent attempts to create the first connection after JVM startup, and could lead to failure for some of the attempts as they fail to provide required details.

It occurs due to accessing the related contents of some caching maps in the opposite order of their population and allowing a narrow window to violate expectation both details would be present. It cant occur again after the first connection creation has passed this point.

...
Caused by: java.lang.IllegalArgumentException: Given Properties object cannot be null
 at org.apache.qpid.jms.util.PropertyUtil.setProperties(PropertyUtil.java:300)
 at org.apache.qpid.jms.util.FactoryFinder$StandaloneObjectFactory.create(FactoryFinder.java:185)
 at org.apache.qpid.jms.util.FactoryFinder.newInstance(FactoryFinder.java:129)
 at org.apache.qpid.jms.provider.ProviderFactory.findProviderFactory(ProviderFactory.java:154)
 ... 18 more