[QPIDJMS-312] Exception is not thrown when user attempts to create context with invalid session mode value

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 0.24.0
• Fix Version/s: 0.25.0
• Component/s: qpid-jms-client
• Assignee: Timothy A. Bish
• Reporter: Jiri Daněk
• Created: 09/Aug/17 07:57
• Updated: 22/Sep/17 14:08
• Resolved: 09/Aug/17 13:57

Description

Consider Apache ActiveMQ Artemis tests org.apache.activemq.artemis.tests.integration.jms.jms2client.JmsContextTest#testInvalidSessionModesValueMinusOne and #testInvalidSessionModesValue4 (in the same class).

When it is adapted to run with multiple JMS clients, or when run from the standalone reproducer at https://github.com/jdanekrh/jms-reproducers/blob/master/src/test/java/org/apache/activemq/artemis/tests/integration/jms/jms2client/JmsContextTest.java
(the standalone reproducer requires a running broker to connect to), the test passes with Core, is skipped on OpenWire (because that is not a JMS 2.0 client) and fails on AMQP protocol (with qpid-jms-client as the JMS library):

   @Test(expected = JMSRuntimeException.class)
   public void testInvalidSessionModesValueMinusOne() {
      context.createContext(-1);
   }

   @Test(expected = JMSRuntimeException.class)
   public void testInvalidSessionModesValue4() {
      context.createContext(4);
   }

with exception

    java.lang.AssertionError: Expected exception: javax.jms.JMSRuntimeException

Issue Links

• is a child of: ARTEMIS-1330 [DISCUSS] Run JMS tests over many protocols (through different JMS client libraries)