[QPIDJMS-243] NPE is reported when failover tries to connect to stopped/not available broker

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.20.0
• Fix Version/s: 0.20.0
• Component/s: qpid-jms-client

Environment

Qpid Broker 7.0.0-SNAPSHOT

• Assignee: Timothy A. Bish
• Reporter: Alex Rudyy
• Created: 30/Dec/16 16:57
• Updated: 20/Jan/17 18:53
• Resolved: 03/Jan/17 22:25

Description

I see the following log issued on failure attempt to establish connection to a stopped(not available) broker listed in failover URL

2016-12-30 16:42:24,738 [localhost:5672]] - WARN  AmqpProvider                   - Caught problem during update processing: null
java.lang.NullPointerException
	at org.apache.qpid.jms.provider.amqp.AmqpConnection.handleResourceClosure(AmqpConnection.java:124)
	at org.apache.qpid.jms.provider.amqp.AmqpAbstractResource.closeResource(AmqpAbstractResource.java:151)
	at org.apache.qpid.jms.provider.amqp.AmqpAbstractResource.processRemoteClose(AmqpAbstractResource.java:257)
	at org.apache.qpid.jms.provider.amqp.AmqpProvider.processUpdates(AmqpProvider.java:850)
	at org.apache.qpid.jms.provider.amqp.AmqpProvider.access$1800(AmqpProvider.java:93)
	at org.apache.qpid.jms.provider.amqp.AmqpProvider$18.run(AmqpProvider.java:784)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
	at java.util.concurrent.FutureTask.run(FutureTask.java:262)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
	at java.lang.Thread.run(Thread.java:745)

The exception does not impact client functionality as client seems continue to work as normal. The exception is reported only on trunk. 0.11 client does not have this issue.