[QPIDJMS-146] potential NPE in transport while establishing SSL connection

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.7.0
• Fix Version/s: 0.8.0
• Component/s: qpid-jms-client
• Assignee: Robbie Gemmell
• Reporter: Robbie Gemmell
• Created: 06/Jan/16 13:08
• Updated: 21/Jul/16 12:17
• Resolved: 06/Jan/16 16:15

Description

There is an issue in the SSL transport, such that it can potentially NPE while establishing the connection, resulting in the attempt hanging.

The issue looks to occur due to the way we are adding a listener to Netty, hitting some inconsistency in thread safety, coupled with unpredictable threading behaviour at the point the listener is added to a future versus it being completed, topped by Netty swallowing the exception when it is thrown.

We should adjust the usage of Netty so that we register the listener earlier such that it gives more predictable thead behaviour and avoids possibility of the NPE.