[QPID-8550] [Broker-J] HP Fortify: Unreleased streams

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: qpid-java-broker-8.0.5
• Fix Version/s: qpid-java-broker-9.0.0
• Component/s: Broker-J
• Assignee: Unassigned
• Reporter: Daniil Kirilyuk
• Created: 14/Jul/21 06:47
• Updated: 11/Nov/22 12:22
• Resolved: 22/Aug/21 18:48

Description

HP Fortify complains about several places where streams potentially do not get released properly:

broker-core/src/main/java/org/apache/qpid/server/store/JsonFileConfigStore.java
The function load() in JsonFileConfigStore.java sometimes fails to release a system resource allocated by FileReader() on line 162.

broker-core/src/main/java/org/org/apache/qpid/server/virtualhostnode/AbstractVirtualHostNode.java
The function getInitialRecords() in AbstractVirtualHostNode.java sometimes fails to release a system resource allocated by ,[object Object], on line 435.

broker-plugins/management-http/src/main/java/org/apache/qpid/server/management/plugin/servlet.rest/RestServlet.java
The function parse() in RestServlet.java sometimes fails to release a system resource allocated by getInputStream() on line 440.

tools/src/main/java/org/apache/qpid/tools/RestStressTestClient.java
The function put() in RestStressTestClient.java sometimes fails to release a system resource allocated by getOutputStream() on line 318.

perftests/src/main/java/org/apache/qpid/disttest/controller/config/ConfigReader.java
The function getConfigFromFile() in ConfigReader.java sometimes fails to release a system resource allocated by getConfigReader() on line 40.

perftests/src/main/java/org/apache/qpid/disttest/controller/config/JavaScriptConfigEvaluator.java
The function evaluateJavaScript() in JavaScriptConfigEvaluator.java sometimes fails to release a system resource allocated by InputStreamReader() on line 70.

The function evaluateJavaScript() in JavaScriptConfigEvaluator.java sometimes fails to release a system resource allocated by InputStreamReader() on line 71.