[QPID-8186] Incorrect exception handling fails to build on GCC 8

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: qpid-cpp-1.38.0
• Fix Version/s: qpid-cpp-1.39.0
• Component/s: C++ Broker

Environment

Gentoo x64, GCC 8.1

• Assignee: Justin Ross
• Reporter: Chris Richardson
• Created: 10/May/18 09:43
• Updated: 14/Dec/19 23:30
• Resolved: 13/May/18 18:05

Description

[ 22%] Building CXX object src/CMakeFiles/qpidcommon.dir/qpid/sys/ssl/check.cpp.o
/home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/sys/posix/SocketAddress.cpp: In member function ‘bool qpid::sys::SocketAddress::isComparable(const qpid::sys::SocketAddress&) const’:
/home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/sys/posix/SocketAddress.cpp:208:18: error: catching polymorphic type ‘class qpid::Exception’ by value [-Werror=catch-value=]
} catch (Exception)

{ ^~~~~~~~~ /home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/sys/posix/SocketAddress.cpp:212:14: error: catching polymorphic type ‘class qpid::Exception’ by value [-Werror=catch-value=] }

catch (Exception) {
^~~~~~~~~

 

 

these "catch (Exception)" statements would better be const ref, which would also fix the build failure.

Issue Links

• links to: GitHub Pull Request #14
• links to: GitHub Pull Request #14