[QPID-7817] [Java Broker] [WebSocket] Websocket implementation must not assume that web socket frame contains a whole AMQP frame

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: qpid-java-broker-7.0.0
• Component/s: Broker-J
• Assignee: Keith Wall
• Reporter: Keith Wall
• Created: 07/Jun/17 18:11
• Updated: 02/Oct/19 19:22
• Resolved: 29/Jun/17 17:33

Description

Currently the Java Broker's AMQP web socket implementation does not uphold all the following:

Advanced Message Queuing Protocol (AMQP) WebSocket Binding (WSB) Version 1.0 Committee Specification 01 2.4 Exchanging AMQP Frames

There is no mapping between an AMQP frame and a WebSocket message. Therefore, a single AMQP frame MAY be split over one or more consecutive WebSocket messages. Conversely, a single WebSocket message MAY contain one or more AMQP frames. There is also no mapping between an AMQP frame and a WebSocket frame. Therefore, a single AMQP frame MAY be split over one or more consecutive WebSocket frames. Conversely, a single WebSocket frame MAY contain one or more AMQP frames.

The current implementation will fail if a websocket frame arrives containing a partial AMQP frame. Furthermore since, QPID-7763, internally WebSocketProvider chunks the incoming bytes into QBBs. If this chunking results in a frame overlapping a chunk boundary, processing will fail.