[QPID-7766] [Java Broker] [Derby Store] Unsigned byte type should be used when reading stored message metada type

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: qpid-java-6.1, qpid-java-6.1.1, qpid-java-6.1.2
• Fix Version/s: qpid-java-6.1.3, qpid-java-broker-7.0.0
• Assignee: Alex Rudyy
• Reporter: Alex Rudyy
• Created: 03/May/17 12:47
• Updated: 01/Jun/17 10:50
• Resolved: 09/May/17 08:21

Description

Meta data type is read into variable of type byte in current implementation of AbstractJDBCMessageStore#getMetaData. As result, the type values above 127 are read as negative values causing ArrayIndexOutOfBoundsException on invocation of MessageMetaDataTypeRegistry#fromOrdinal. Unsigned byte type should be used when reading stored message meatada type.

This defect prevents the recovery of "flowed to disk" messages published with REST API or AMQP management, because metadata type for such messages is 255 which is turned into -1 when signed byte is used.