[QPID-7719] [Java Broker] Set response code to 500 when unexpected error occurs during REST call

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: qpid-java-broker-7.0.0
• Component/s: Broker-J
• Assignee: Alex Rudyy
• Reporter: Lorenz Quack
• Created: 22/Mar/17 10:53
• Updated: 14/Nov/17 21:59
• Resolved: 26/Apr/17 13:11

Description

Currently if there is an unhandled exception in the REST layer we do not set a error response code. The servlet ends up returning 200 which is clearly incorrect.
we should set the error code to 500 and ideally return a JSON error message.

The code in question is the final else block in RestServlet#setResponseStatus (~line 960).