[QPID-7629] Use CMake "SYSTEM" keyword when including headers

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: qpid-cpp-1.36.0
• Fix Version/s: qpid-cpp-1.37.0
• Component/s: C++ Broker, C++ Client
• Labels: patch
• Assignee: Justin Ross
• Reporter: Chris Richardson
• Created: 18/Jan/17 14:19
• Updated: 23/Mar/17 12:57
• Resolved: 23/Mar/17 12:57

Description

See attached patch which applies this change to the NSS and SASL include directories. The patch does not affect the included headers from perl, python, ruby, boost or qpid-proton since it is probably not necessary to consider those dependencies.

This change would prevent -Werror being applied to code in header files included from dependent libraries, which can cause failures such as:

[ 25%] Building CXX object src/CMakeFiles/qpidcommon.dir/qpid/Modules.cpp.o
In file included from /usr/include/nss/ssl.h:18:0,
from /var/tmp/portage/net-misc/qpid-cpp-1.36.0/work/qpid-cpp-1.36.0/src/qpid/sys/ssl/util.cpp:30:
/usr/include/nss/sslt.h:121:40: error: comma at end of enumerator list [-Werror=pedantic]
ssl_sig_rsa_pkcs1_sha1md5 = 0x10101,
^
cc1plus: all warnings being treated as errors

Issue Links

• is related to: QPID-7714 Suppress auto_ptr warnings