[QPID-7537] Improve implementations of equal methods in various classes to be able to account for sub-classes

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: qpid-java-broker-7.0.0, qpid-java-client-0-x-6.3.0
• Component/s: Broker-J, Java Common, Java Performance Tests, JMS AMQP 0-x
• Assignee: Keith Wall
• Reporter: Alex Rudyy
• Created: 21/Nov/16 16:19
• Updated: 14/Nov/17 22:01
• Resolved: 25/Nov/16 14:43

Description

The equals method of the following classes break symmetry if the passed in object is a subclass. Use this.getClass() instead of instanceof.

• BindingImpl
• QpidSslRMIServerSocketFactory
• HeadersBinding
• AMQPProtocolVersionWrapper
• UsernamePrincipal
• GroupPrincipal
• Action
• Rule
• InetNetwork
• AMQBrokerDetails
• AMQDestination
• AMQQueue
• AMQTopic
• XidImpl
• FieldTable
• ProtocolInitiation
• QpidRAConnectionRequestInfo
• QpidRAManagedConnectionFactory
• QpidRAMessage
• QpidResourceAdapter
• ListPropertyValue
• NumericGeneratedPropertySupport
• RangePropertyValue