[QPID-7468] [Java Broker] Upgrade logback to 1.1.11 and SLF4J to 1.7.24

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: qpid-java-6.0.4
• Fix Version/s: qpid-java-6.0.7, qpid-java-6.1.3, qpid-java-broker-7.0.0
• Component/s: Broker-J
• Assignee: Alex Rudyy
• Reporter: Alberto
• Created: 24/Oct/16 16:45
• Updated: 02/Oct/19 19:21
• Resolved: 25/May/17 12:29

Description

The current version used in qpid-broker 6.0.4 for logback is 1.1.3. With the version 1.1.7 logback broke backwards compatibility in StatusManager interface (ch.qos.logback.core.status.StatusManager).

After this change, BrokerFileLoggerImpl is failing to add the `BrokerFileLoggerStatusListener` to the loggerContext due to binary incompatibility (See line 210 of BrokerFileLoggerImpl for more info).

 @Override
    protected Appender<ILoggingEvent> createAppenderInstance(Context loggerContext)
    {
        SystemConfig<?> systemConfig = (SystemConfig<?>)getParent(Broker.class).getParent(SystemConfig.class);
        _logbackStatusListener = new BrokerFileLoggerStatusListener(this, systemConfig);
        _statusManager = loggerContext.getStatusManager();
        _statusManager.add(_logbackStatusListener);

        final RollingFileAppender<ILoggingEvent> appender = new RollingFileAppender<>();
        AppenderUtils.configureRollingFileAppender(this, loggerContext, appender);
        return appender;
    }

We've noticed this after update spring boot to the latest version 1.4.1.Release which includes logback 1.1.7.

As a workaround, you can still downgrade your version of logback in your project to 1.1.3 but it would be nice to have it upgraded

Issue Links

• links to: GitHub Pull Request #1