[QPID-7459] ProducerFlowControlTest#testSendTimeout test fails sprodically on 0-10 profiles

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: qpid-java-broker-7.0.0
• Component/s: Java Tests
• Assignee: Unassigned
• Reporter: Keith Wall
• Created: 14/Oct/16 10:17
• Updated: 20/Jun/17 16:20
• Resolved: 20/Jun/17 16:20

Description

ProducerFlowControlTest#testSendTimeout test fails sprodically on 0-10 profiles.

The test is racey. The test relies on message n-1 causing flow control to be imposed before the test can try to send message n. If flow control is not imposed before the client tries to send message n, the test will fail. In the failing case the client has not processed the incoming MessageStop before it sends message n. The test tries tries to prevent this by sync'ing twice. This approach is ineffective for 0-10 as the send sync to optimised out and does not caused an ExecutionSync.

The test issue does not affect the usefulness of the feature itself.

https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-Java-Java-Test-JDK1.8/1801/artifact/trunk/systests/target/surefire-reports/java-mms.0-10/

junit.framework.AssertionFailedError: No timeout exception on sending
	at junit.framework.Assert.fail(Assert.java:57)
	at junit.framework.Assert.assertTrue(Assert.java:22)
	at junit.framework.Assert.assertNotNull(Assert.java:256)
	at junit.framework.TestCase.assertNotNull(TestCase.java:426)
	at org.apache.qpid.server.queue.ProducerFlowControlTest.testSendTimeout(ProducerFlowControlTest.java:284)

Issue Links

• is related to: QPID-7458 ProducerFlowControlTest#testSendTimeout test fails sprodically on 0-10 profiles