Uploaded image for project: 'Qpid'
  1. Qpid
  2. QPID-7440

[Java Broker] Stop ProtocolOutputConverterImpl from leaking QpidByteBuffers

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • qpid-java-6.0, qpid-java-6.0.5, qpid-java-6.1
    • qpid-java-6.1
    • Broker-J
    • None

    Description

      ProtocolOutputConverterImpl seems to leak QBBs in deflateIfPossible and inflateIfPossible. Those methods pass QBBs from MessageContentSource.getContent() to QBB.deflate/inflate but those methods do not take ownership of the buffers so they are not disposed of.

      Keith thinks that ownership should remain with the caller and that ProtocolOutputConverterImpl should dispose of the QBBs.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            lorenz.quack Lorenz Quack
            lorenz.quack Lorenz Quack
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Issue deployment