[QPID-7161] System test output lost owing to orphaned shutdown hooks

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Component/s: Broker-J, Java Tests
• Assignee: Lorenz Quack
• Reporter: Keith Wall
• Created: 24/Mar/16 17:15
• Updated: 02/Oct/19 19:22
• Resolved: 29/Mar/16 08:27

Description

When the Broker exits, normally AbstractSystemConfig organises for the shutdown hook to be removed (#onClose). If AbstractSystemConfig fails to close all its children, the step to remove the shutdown hook never gets executed. For normal production use cases this is harmless; the Broker is going down anyway. However when testing the Broker using its system test suite this is problematic.

Our Logback configuration associates threads to test specific log file. The ShutdownHook still maintains this association, even though QpidTestCase has already told Logback that the test is through org.slf4j.MDC#remove. As Logback believes the test is through, when the Shutdown hook awakes and logs, Logback truncates the tests' logfiles, removing the details of why the test actually failed in the first place.