[QPID-7108] [Java Broker] Test BDBHAVirtualHostNodeTest.testIntruderProtection is failing sporadically

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: qpid-java-6.0, qpid-java-6.0.1, qpid-java-6.1
• Fix Version/s: qpid-java-6.1
• Component/s: Java Tests
• Assignee: Unassigned
• Reporter: Alex Rudyy
• Created: 26/Feb/16 12:11
• Updated: 13/Jun/16 10:27
• Resolved: 26/Feb/16 17:54

Description

The test BDBHAVirtualHostNodeTest.testIntruderProtection tries to remove the permitted node from a list of permitted nodes in order to make it an intruder node.

That it is not allowed as currently on changing of permitted nodes an existing implementation verifies that specified permitted nodes includes all nodes in a group. See changes made in QPID-6090 ( [Java Broker] Prevent removal of existing group nodes from the permitted nodes attribute on VHN).

The test should simply connect an intruder and verify that it cannot start up with intruder present.

Here are the exception details for the test as it is reported in jenkins

The current group node 'localhost:10001' cannot be removed from 'permittedNodes' as its already a group member

Stacktrace

java.lang.IllegalArgumentException: The current group node 'localhost:10001' cannot be removed from 'permittedNodes' as its already a group member
	at org.apache.qpid.server.virtualhostnode.berkeleydb.BDBHAVirtualHostNodeImpl.validatePermittedNodes(BDBHAVirtualHostNodeImpl.java:1007)
	at org.apache.qpid.server.virtualhostnode.berkeleydb.BDBHAVirtualHostNodeImpl.validateChange(BDBHAVirtualHostNodeImpl.java:185)
	at org.apache.qpid.server.model.AbstractConfiguredObject$23.execute(AbstractConfiguredObject.java:2382)
	at org.apache.qpid.server.model.AbstractConfiguredObject$23.execute(AbstractConfiguredObject.java:2377)
	at org.apache.qpid.server.configuration.updater.TaskExecutorImpl$TaskLoggingWrapper.execute(TaskExecutorImpl.java:270)
	at org.apache.qpid.server.configuration.updater.TaskExecutorImpl$CallableWrapper$1.run(TaskExecutorImpl.java:342)
	at java.security.AccessController.doPrivileged(Native Method)
	at javax.security.auth.Subject.doAs(Subject.java:356)
	at org.apache.qpid.server.configuration.updater.TaskExecutorImpl$CallableWrapper.call(TaskExecutorImpl.java:335)
	at java.util.concurrent.FutureTask.run(FutureTask.java:262)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
	at java.lang.Thread.run(Thread.java:745)