[QPID-6684] Asynchronous state change exceptions not passed back to caller

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: qpid-java-6.0
• Component/s: Broker-J
• Assignee: Alex Rudyy
• Reporter: Keith Wall
• Created: 09/Aug/15 07:35
• Updated: 02/Oct/19 19:22
• Resolved: 12/Nov/15 00:11

Description

A defect in the following part of the ACO#doAttainState means that an asynchronous exception occurring in a state change method is lost and not propagated back via the future returned to the caller.

 
       final SettableFuture<Void> returnVal = SettableFuture.create();
        final ChildCounter counter = new ChildCounter(new Runnable()
        {
            @Override
            public void run()
            {
                try
                {
### If future returned by attainState contains an exception, it is lost.  returnVal future completes normally regardless..
                    attainState().addListener(new Runnable()
                    {
                        @Override
                        public void run()
                        {
                            returnVal.set(null);
                        }
                    }, getTaskExecutor().getExecutor());
                }
                catch(RuntimeException e)
                {
                    try
                    {
                        exceptionHandler.handleException(e, AbstractConfiguredObject.this);
                        returnVal.set(null);
                    }
                    catch(Throwable t)
                    {
                        returnVal.setException(t);
                    }
                }
            }
        });