[QPID-6507] Eliminate HelperServlet from web management console

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: qpid-java-6.0
• Component/s: Broker-J
• Assignee: Alex Rudyy
• Reporter: Alex Rudyy
• Created: 23/Apr/15 16:30
• Updated: 16/Jun/15 21:44
• Resolved: 16/Jun/15 21:44

Description

The HelperServlet is most already dead code or code that can be replaced by common mechanisms of the metadata service.

1. ListBrokerAttribute,ListGroupProviderAttributes, ListAccessControlProviderAttributes are dead code. The web management code has stopped calling these actions.
2. PluginClassProviderAction is used only for getting a list of JDBCConnectionProviderFactories. This can be replaced with a validValue attribute on JDBCVirtualHostNode#connectionPoolType and JDBCVirtualHost#connectionPoolType that gets its domain programmatically from the QpidServiceLoader. See org.apache.qpid.server.model.port.AmqpPort#getProtocols and its validValues method for an example.
3. The function of ListTimeZones is still required. We could move the functionality to a dedicated servlet

The web management code call the HelperServlet (look for HTTP calls with action=) must be refactored to retain current functionality.