[QPID-6451] ProtocolVersionException exception logged at error as Java Client downgrades from 0-10

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.32
• Fix Version/s: qpid-java-6.0
• Component/s: JMS AMQP 0-x
• Assignee: Alex Rudyy
• Reporter: Keith Wall
• Created: 14/Mar/15 18:53
• Updated: 02/Oct/19 19:20
• Resolved: 17/Jun/15 23:18

Description

Since QPID-6350, the Java Client 0-10 has been logging ConnectionExceptions at SLF4J error. Unfortunately this change also causes ProtocolVersionException (and RedirectConnectionException) to be logged too. These exceptions don't represent true error conditions, so logging them at error is inappropriate.

Whilst this change does not cause a functional issue, it has the potential to confuse users and can unnecessarily pollute logs.

2015-03-14 18:40:13,562 ERROR [IoReceiver-localhost/127.0.0.1:15672] (transport.Connection) - exception: version mismatch: 0-9
org.apache.qpid.transport.ProtocolVersionException: version mismatch: 0-9
        at org.apache.qpid.transport.ClientDelegate.init(ClientDelegate.java:61)
        at org.apache.qpid.transport.ClientDelegate.init(ClientDelegate.java:44)
        at org.apache.qpid.transport.ProtocolHeader.delegate(ProtocolHeader.java:110)
        at org.apache.qpid.transport.Connection.received(Connection.java:416)
        at org.apache.qpid.transport.network.Assembler.emit(Assembler.java:98)
        at org.apache.qpid.transport.network.Assembler.init(Assembler.java:118)
        at org.apache.qpid.transport.ProtocolHeader.delegate(ProtocolHeader.java:115)
        at org.apache.qpid.transport.network.Assembler.received(Assembler.java:103)
        at org.apache.qpid.transport.network.InputHandler.next(InputHandler.java:163)
        at org.apache.qpid.transport.network.InputHandler.received(InputHandler.java:115)
        at org.apache.qpid.transport.network.io.IoReceiver.run(IoReceiver.java:161)
        at java.lang.Thread.run(Thread.java:745)