[QPID-6381] [Java Broker] [AMQP 1.0] the 'closed' field is ignored when detaching

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.31
• Fix Version/s: 0.31
• Component/s: Broker-J
• Assignee: Robert Godfrey
• Reporter: Robbie Gemmell
• Created: 10/Feb/15 17:44
• Updated: 19/Mar/15 12:22
• Resolved: 12/Feb/15 12:54

Description

The broker does not currently inspect the closed flag of the Detach when deciding whether to close detaching consumer links, and instead seems to base its action on the terminus durability.

E.g in SendingLink_1_0.remoteDetached(LinkEndpoint, Detach), it inspects the source terminus-durability and closes [almost] everything that is not specifying UNSETTLED_STATE durability:

        //TODO
        // if not durable or close
        if(!TerminusDurability.UNSETTLED_STATE.equals(_durability))
        {

This is presumably the reason that QPID-6380 does not result in removal of the DurableSubscription backing queue when 'closing' a JMS durable TopicSubscriber from the 'existing' AMQP 1.0 JMS client, as it uses UNSETTLED_STATE durability on those links.

Issue Links

• relates to: QPID-6380 [AMQP 1.0 JMS Client ] detach with closed=true is issued when making durable subscriber inactive