[QPID-6380] [AMQP 1.0 JMS Client ] detach with closed=true is issued when making durable subscriber inactive

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.31
• Fix Version/s: 0.31
• Labels: legacy-jms-amqp-1.0-client

Environment

trunk / 0.31 Java broker

• Assignee: Robert Godfrey
• Reporter: Robbie Gemmell
• Created: 10/Feb/15 17:38
• Updated: 14/Mar/17 12:39
• Resolved: 11/Feb/15 16:46

Description

When a JMS application 'closes' its durable TopicSubscriber this leaves its subscription in place but inactive. Currently the client conveys this by detaching the link with closed=true.

<TCP time="12:42:19.923318" seqno="1430029142" size="16">
  <source host="127.0.0.1" port="60461"/>
  <target host="127.0.0.1" port="5672"/>
  
  <frame size="16" doff="2" chan="1"> 
    
    <small-descriptor code="0x0:0x16"/> # detach
    <list8 size="3" count="2"> # detach
      <uint0/> # handle
      <true/> # closed
      # <null/> error
    </list8>
    
  </frame>
  
</TCP>

The broker replies, but saying the link actually is not closed, and leaving the subscription in place despite the requested close.

<TCP time="12:42:19.924734" seqno="1820218247" size="15">
  <source host="127.0.0.1" port="5672"/>
  <target host="127.0.0.1" port="60461"/>
  
  <frame size="15" doff="2" chan="1"> 
    
    <small-descriptor code="0x0:0x16"/> # detach
    <list8 size="2" count="1"> # detach
      <uint0/> # handle
      # <null/> closed [false]
      # <null/> error
    </list8>
    
  </frame>
  
</TCP>

The client should use closed=false on the link detach, when 'closing' the JMS subscriber. The separate unsubscribe can then actually close the link (as it already does, in addition to other things) to indicate end of the subscription.

Issue Links

• is related to: QPID-6381 [Java Broker] [AMQP 1.0] the 'closed' field is ignored when detaching