[QPID-6248] [linearstore] Symlink creation fails if store dir path is not absolute

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.30
• Fix Version/s: 0.31
• Component/s: C++ Broker
• Assignee: Kim van der Riet
• Reporter: Kim van der Riet
• Created: 25/Nov/14 15:44
• Updated: 19/Mar/15 12:22
• Resolved: 25/Nov/14 20:44

Description

Thanks to Alan Conway for finding this bug:

I uncovered a bug in the way symlinks are created if the data directory
is not an absolute path. It appears that the code creating the symlink
assumes that the path is absolute, which gives invalid symlinks. For
example in the following the brokers working directory
is /home/aconway/qpid/debug/src/tests/interop_tests.tmp/interop_tests.PythonTxTest.test_tx_simple_rollback
and the data dir is "broker2"

2014-11-18 11:26:33.216699232 [Store] debug Linear Store: Journal
"TplStore":Journal directory = "broker2/qls/tpl/"

ls -l /home/aconway/qpid/debug/src/tests/interop_tests.tmp/interop_tests.PythonTxTest.test_tx_simple_rollback/broker2/qls/jrnl/interop_tests.PythonTxTest.test_tx_simple_rollback-a
total 4
lrwxrwxrwx. 1 aconway aconway 71 Nov 18 11:18 3ee76ade-3793-4056-ac39-98f566cb345e.jrnl -> broker2/qls/p001/2048k/in_use/3ee76ade-3793-4056-ac39-98f566cb345e.jrnl
[aconway@wallace dispatch (trunk)]$ 	

I think you should be resolving the path to an absolute path (relative to current working dir) before creating the symlink.