[QPID-6189] [Java Common] 0-8/9/9-1 parser can cause stack overflow if a frame is broken into many TCP reads/writes

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.31
• Component/s: Java Common
• Assignee: Robert Godfrey
• Reporter: Robert Godfrey
• Created: 27/Oct/14 13:50
• Updated: 09/Aug/16 13:28
• Resolved: 12/Feb/15 12:54

Description

When an entire frame is split over many TCP reads/writes the 0-8/9/9-1 codec is effectively using tail recursion to iterate over the buffers to parse the whole frame. When there are a lot of buffers this can cause stack overflow. To guard against this we can simply squash the multiple buffers into a single buffer when we cross a threshold number of buffers.