[QPID-6171] [Java Common] Connection.getChannels() leaks a potentially thread-unsafe data structure

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.31
• Component/s: Java Common
• Assignee: Robert Godfrey
• Reporter: Robert Godfrey
• Created: 21/Oct/14 11:32
• Updated: 19/Mar/15 12:23
• Resolved: 21/Oct/14 16:38

Description

the collection returned by getChannels() may be modified by other threads, leading to unsafe iteration throwing ConcurrentModificationException.

The returned object should instead be a copy of the data and the underlying map should use a thread safe implementation to allow for the safe copying of the values() collection while another thread may be modifying the map.