[QPID-6117] [08..091] Race condition during close causes sporadic test failure

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.31
• Component/s: Python Client

Environment

Python 2.7.5 (default, Mar 9 2014, 22:15:05)
Mac OS X Darwin 13.3.0 Darwin Kernel Version 13.3.0: Tue Jun 3 21:27:35 PDT 2014; root:xnu-2422.110.17~1/RELEASE_X86_64 x86_64

• Assignee: Alex Rudyy
• Reporter: Keith Wall
• Created: 25/Sep/14 13:25
• Updated: 02/Oct/19 19:20
• Resolved: 19/Mar/15 12:49

Description

Running the Python suit (08..091) on a Mac shows a sporadic test failure with the following stack trace:

Error during teardown:  Traceback (most recent call last):
    File "./qpid-python-test", line 340, in run
      phase()
    File "/Users/keith/src/qpid/qpid/python/qpid/testlib.py", line 77, in tearDown
      self.client.close()
    File "/Users/keith/src/qpid/qpid/python/qpid/client.py", line 129, in close
      self.socket.close()
    File "/Users/keith/src/qpid/qpid/python/qpid/connection08.py", line 63, in close
      self.sock.shutdown(SHUT_RDWR)
    File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/socket.py", line 224, in meth
      return getattr(self._sock,name)(*args)
  error: [Errno 57] Socket is not connected

The issue is a race between the client and server side. The unlucky timing (causing the stack trace) is where the server side closes the socket first, meaning the client's attempt to shutdown down the socket throws error 57.