[QPID-5886] C++ Broker OutgoingMessage change exposes Completion handle export issue on Windows

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.29
• Fix Version/s: 0.29
• Component/s: C++ Broker, C++ Client

Environment

Wiindows trunk

• Assignee: Charles E. Rolke
• Reporter: Charles E. Rolke
• Created: 09/Jul/14 21:56
• Updated: 26/Sep/14 15:43
• Resolved: 10/Jul/14 11:36

Description

Windows builds have been failing mysteriously for me for a few weeks[1]. I found the issues/ QPID-5828 r1604952 changed OutgoingMessage such that the Completion object now needs to access Handle<CompletionImpl>::isValid().

Simply instantiating the Handle superclass (r1525706 for example) didn't work. On windows the classes won't export from a .h file but need to come from .cpp files. Review is coming up shortly.

[1] Why some builds work and some don't is unsolved.